Spencer131
Veteran
That is certainly a possibility.
However I don't want to add every feature under the sun and become cluttered like cstimer (no offense to them tho
)If enough people want the ability to exclude events, I can make it happen.
website to calculate kinch rank / sum of ranks
- Thread starter Spencer131
- Start date
However I don't want to add every feature under the sun and become cluttered like cstimer (no offense to them tho
)If enough people want the ability to exclude events, I can make it happen.
UncleFrank
Veteran
I picked a random person from WCA's list
#100 SoR averages, Rami Sbahi
Entered him into your calculator for SoR average, and I get a listing of #101-120, but no #100 Rami Sbahi.
Last edited:
Topher_
Member
What are the scores needed for each rank (needs works/okay/ etc.)
Spencer131
Veteran
Thank you for letting me know. If I understand correctly, it seems to be a problem with the WCA API, as I am using their public API.
If you go to WCA sum of ranks page, and put in 2011SBAH01, you see the same issue. It displays #101-120 but not #100. Their API gives results in batches of 20, and if you try to get a person who is an exact multiple of 20, it actually gives you the NEXT batch.
I will reach out to WCA about this.
- Joined
- Jun 7, 2007
- Messages
- 11,932
- Location
- Indianapolis
- WCA ID
- 2007HUGH01
- YouTube
- Visit Channel
Looks like an off by 1 error in the list fetch. If you enter Christopher Chi (#99) into the calculator, you'll see Rami at #100 in the listing there.
Edit: sorry, I was ninjaed by Spencer131.
Spencer131
Veteran
Here's the exact code lol. It's basically divided into fourths
Code:
if (score < 100 / 4) {
return "Needs work";
} else if (score < 100 * 2 / 4) {
return "Okay";
} else if (score < 100 * 3 / 4) {
return "Good";
} else if (score < 100) {
return "Excellent";
}
return "World record!";Spencer131
Veteran
I've opened a pull request in the WCA repository to fix the off-by-one issue. If they accept the pull request, then it should fix the error for CubingApp as well
Spencer131
Veteran
This has been fixed in the cubingapp calculator: https://cubingapp.com/calculate-sum-of-ranks.html?wcaId=2011SBAH01
And of course it wouldn't be possible without the help of Alex Campos on the code change
D
Deleted member 74176
Guest
I tried using the SoR calculator, but my name doesn't show up.
Here's a link: https://cubingapp.com/calculate-sum-of-ranks.html?wcaId=2021STRA04
Here's a link: https://cubingapp.com/calculate-sum-of-ranks.html?wcaId=2021STRA04
Spencer131
Veteran
I made a change and it should work know (hopefully!)
Similar threads
