• Welcome to the Speedsolving.com, home of the web's largest puzzle community!
    You are currently viewing our forum as a guest which gives you limited access to join discussions and access our other features.

    Registration is fast, simple and absolutely free so please, join our community of 40,000+ people from around the world today!

    If you are already a member, simply login to hide this message and begin participating in the community!

Roseftrainer - A small program to help memorize letterpairs for blindsolving a rubik's cube.

Sir E Brum

Member
Joined
Sep 24, 2008
Messages
414
Location
San Antonio, TX
WCA
2010HANN01
I like the concept of your program, but the code is horrendous.
https://stackoverflow.com/questions/19158339/why-are-global-variables-evil

The exclusive use of globals is the most glaring issue. Others being:
1) No classes.
2) All operations for drawing the windows are outside of functions.
3) Variables with the same name and different capitalization.
4) The entire guesses calculation system is a mess. Don't store the last 20 in a list. Store it all (memory is cheap) using guesses.append(x) and just do your calculations via sum(guesses[-20:]) / 20 to get percentages.

The worst part about this though, and I really do feel bad for you on this one, programs like Mnemosyne, Anki, and SuperMemo have been around forever and accomplish what you are doing much more efficiently using spaced repetition.
 
Top